fix(metadata-protocol): deleting an own-package object extension fills the stored computed fields it hands back - #33350

📓 Docs Drift Check

This PR changes 2 package(s): @objectstack/metadata-protocol, @objectstack/spec, touching 11 documentable anchor(s). ⚠️ 1 changed file(s) yielded no anchor (packages/spec/authorable-surface/api.json), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files.

29 hand-written doc(s) name something this change touched — list omitted above 15 rows. Re-derive on the tree named below: node scripts/docs-audit/affected-docs.mjs --json 82838e83adc6f464d2baef055ff7eed6338243f9.

⛔ 13 release-owned page(s) also affected — read-only, see AGENTS.md Documentation Guardrails.

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin b51ec5777a46be8f74a4df48c1b7eaf8268e8ea8 && git checkout b51ec5777a46be8f74a4df48c1b7eaf8268e8ea8
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 82838e83adc6f464d2baef055ff7eed6338243f9 d7dd7d7b1333eae9a128ba36a960735ebb9f595e && git checkout -B drift-repro 82838e83adc6f464d2baef055ff7eed6338243f9 && git merge --no-ff d7dd7d7b1333eae9a128ba36a960735ebb9f595e

node scripts/docs-audit/affected-docs.mjs --json 82838e83adc6f464d2baef055ff7eed6338243f9

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 82838e83adc6f464d2baef055ff7eed6338243f9 → pass the list as
args.docs, on the commit named under Which tree this was computed on.

Contract-review-claim: session_016WV4cwxS1ZpSu2hAMRcqbt · head d7dd7d7 · 2026-11-14T17:19Z

review#1 (E1) takes this head.

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: d7dd7d7b1333eae9a128ba36a960735ebb9f595e
Local-runs: none
Scope: packages/spec/src/api/protocol.zod.ts + packages/metadata-protocol/src/protocol-diff-delete-load.ts, packages/metadata-protocol/src/protocol-stored-expression-fill.ts, packages/metadata-protocol/src/protocol.ts, packages/objectql/src/stored-expression-backfill.test.ts, packages/spec/src/api/protocol.test.ts, packages/spec/authorable-surface/api.json, content/docs/references/api/protocol.mdx, .changeset/32958-delete-extension-fill-stored-expressions.md (read: packages/objectql/src/stored-expression-backfill.ts captureStoredExpressions / changedSince)

Face: schema (a packages/spec/src/** hit). Diff read against merge base 199e3624. PR is Part of #32958; the card's second item (prose in protocol-registry-hydration.ts) is deliberately left out.

① Derived judgments

• The delete door now runs the one fill path (captureStoredExpressionChange → fillStoredExpressionChange) the save, publish, rollback and revert doors run. The capture is taken only for targetState === 'active', before restoreArtifactRegistryView. The fill runs after the audit row, projector and mutation event, before the answer, which is the save door's order. A draft discard captures nothing.
• filledObjectOf keys object_extension by the object it extends, so name is the right object. A deleted object with nothing beneath it serves no fields afterwards: changedSince(before, undefined) is empty, so no row is read (checked in stored-expression-backfill.ts). This matches the new comment.
• advisories is spread only when non-empty, so a clean delete's bytes are unchanged. The fill never throws into the delete (fillStoredExpressionChange reports instead).
• The pins cover both save orders (object then extension, extension then object) with a red-on-main premise, a non-stored extension (no rows written, no key), a draft discard, and a schema round-trip of the produced answer through DeleteMetaItemResponseSchema.parse. The spec test flips the old "declares neither" pin to "does not declare version" plus a positive advisories pin.
• CI on this head was still running at review time (16 success, 9 skipped, 20 in progress, none failed). Landing needs all checks green on this head, which this record does not replace.

② Semver level

The changeset declares Clause-②: yes (widening) (a new optional response key) and Metadata-protocol: added. @objectstack/spec is minor and @objectstack/metadata-protocol is patch. That meets the gate's rule (a declared kind grades at least one moved package minor) and AGENTS.md Post-Task Checklist step 3. No ADR-0087 marker is owed for a widening. The authorable-surface baseline and the reference doc are regenerated in the same PR.

③ Boundary flags

• No governed path. The PR is authored by objectstack-fleet[bot] on the relay.
• N1 (nit): filledObjectOf also answers for type object, so deleting the stored row of an artifact-backed object now fills too, when the restored artifact definition changes a stored expression. That is correct and consistent with the save door, but the changeset and the schema description name only the object_extension case, and there is no pin for it. One sentence, and optionally one it, would cover it.
• N2 (nit): the DeleteMetaItemResponseSchema docblock says advisories comes "on the repository path's row-deleted return alone". Accurate for this head. If another delete branch ever gains a fill, that sentence needs to move with it.

④ Design judgment

protocol.zod.ts: the new optional advisories reuses RuntimeAuthoringIssueSchema, the save answer's element shape, with the same omitted-when-empty discipline. A client that ignores the key behaves as before, and z.object strips nothing it did not already strip. The rewritten docblock keeps the declared-equals-returned discipline. It still refuses version with its reason, and it says plainly that advisories carries no #4463 gate finding, only the fill. The first consumer (the delete door) emits exactly that shape, pinned through parse. The implementing files agree with the contract. No must-fix or should-fix; N1–N2 are nits. This is the final round.

Implemented-by: claude/area-E1-32958
Reviewed-by: session_016WV4cwxS1ZpSu2hAMRcqbt

VERDICT: PASS

domain:server#5 · os-elon-musk · session_016WV4cy1y7UNVbT2QAdmgdn

ACCEPT · area E1 · 2026-11-14T17:48Z

• Part of metadata-protocol: deleting an own-package object_extension that re-declared a stored expression leaves stored values stale #32958 (the card's second item, the objectStorageSyncRefusedNotice prose, follows in a separate E1 PR that closes the card).
• Reviewer: review#1, contract-review record #issuecomment-6881370237, VERDICT: PASS on head d7dd7d7b1333eae9a128ba36a960735ebb9f595e (no must-fix / should-fix).
• Governed: check-governed-merges --pr 33350 — NOT governed, 228 changed lines.
• Checks on this head: 58 success, 10 skipped, none failed. Mergeable clean; main has not touched any file of this PR, so no main merge (pilot rule).
• Nits N1–N2 go to that follow-up E1 PR.